lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] writeback: make writeback_control.nr_to_write straight
I'd rather see this earlier in the series, before the write bandwith
estimation ones, as it's groundwork independ of those changes.

> + if (wrote) {
> + if (jiffies - start_time > HZ / 10UL)
> + break;
> + if (work->nr_pages <= 0)
> + break;
> + }

This code probably wants some comments.

> static void bdi_flush_io(struct backing_dev_info *bdi)
> {
> - struct writeback_control wbc = {
> - .sync_mode = WB_SYNC_NONE,
> - .older_than_this = NULL,
> - .range_cyclic = 1,
> - .nr_to_write = 1024,
> - };
> -
> - writeback_inodes_wb(&bdi->wb, &wbc);
> + writeback_inodes_wb(&bdi->wb, 1024);
> }

At this point you could probably also kill the bdi_flush_io wrapper, and
just call writeback_inodes_wb directly. A comment on the 1024 pages to
write would be nice, if you remember it from poking the code. I can't
find any good explanation for it offhand.



\
 
 \ /
  Last update: 2011-06-19 17:39    [W:0.126 / U:2.356 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site