Messages in this thread | | | Date | Sun, 19 Jun 2011 11:35:36 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 5/7] writeback: make writeback_control.nr_to_write straight |
| |
I'd rather see this earlier in the series, before the write bandwith estimation ones, as it's groundwork independ of those changes.
> + if (wrote) { > + if (jiffies - start_time > HZ / 10UL) > + break; > + if (work->nr_pages <= 0) > + break; > + }
This code probably wants some comments.
> static void bdi_flush_io(struct backing_dev_info *bdi) > { > - struct writeback_control wbc = { > - .sync_mode = WB_SYNC_NONE, > - .older_than_this = NULL, > - .range_cyclic = 1, > - .nr_to_write = 1024, > - }; > - > - writeback_inodes_wb(&bdi->wb, &wbc); > + writeback_inodes_wb(&bdi->wb, 1024); > }
At this point you could probably also kill the bdi_flush_io wrapper, and just call writeback_inodes_wb directly. A comment on the 1024 pages to write would be nice, if you remember it from poking the code. I can't find any good explanation for it offhand.
| |