lkml.org 
[lkml]   [2011]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/3] net/fec: add device tree support
    Date
    On Saturday 18 June 2011 17:19:13 Shawn Guo wrote:
    > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
    > new file mode 100644
    > index 0000000..705111d
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
    > @@ -0,0 +1,14 @@
    > +* Freescale Fast Ethernet Controller (FEC)
    > +
    > +Required properties:
    > +- compatible : should be "fsl,<soc>-fec", "fsl,fec"
    > +- reg : address and length of the register set for the device
    > +- interrupts : should contain fec interrupt
    > +
    > +Example:
    > +
    > +fec@83fec000 {
    > + compatible = "fsl,imx51-fec", "fsl,fec";
    > + reg = <0x83fec000 0x4000>;
    > + interrupts = <87>;
    > +};

    How about also adding device_type="network" as required here, so you
    inherit the attributes like "local-mac-address".

    I would also suggest adding a call to of_get_mac_address() so you
    can read the address out of the device tree when it is not configured
    in hardware. Today, the driver relies on a module parameter or
    platform_data on hardware with a mac address set.

    The other information that is currently encoded in platform_data
    is the phy mode. How about adding a property that enables RMII mode
    when present?

    Arnd


    \
     
     \ /
      Last update: 2011-06-18 20:31    [W:0.022 / U:0.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site