Messages in this thread | | | Subject | Re: [PATCH] sched: find all lowest run-queues for RT task | From | Steven Rostedt <> | Date | Thu, 16 Jun 2011 12:57:25 -0400 |
| |
On Thu, 2011-06-16 at 12:52 -0400, Steven Rostedt wrote:
> > diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c > > index 2722dc1..d4c0b46 100644 > > --- a/kernel/sched_cpupri.c > > +++ b/kernel/sched_cpupri.c > > @@ -181,8 +181,10 @@ int cpupri_init(struct cpupri *cp) > > goto cleanup; > > } > > > > - for_each_possible_cpu(i) > > + for_each_possible_cpu(i) { > > cp->cpu_to_pri[i] = CPUPRI_INVALID; > > + cpupri_set(cp, i, MAX_RT_PRIO); > > + } > > This is OK, and I may add it. It's just an initialization, and because > things like the migration thread run on all CPUs, the first time an RT > task is run on a CPU and dequeued, it will have the cpupri_set() to > MX_RT_PRIO anyway. But for clean up sake, it may be good to initialize > it to a valid mask and not be ZERO. >
I take it back, this isn't needed either, as the cpupri_set() is initialized when the rq comes on line.
-- Steve
| |