Messages in this thread Patch in this message | | | Date | Thu, 16 Jun 2011 12:09:37 +0200 | From | Ingo Molnar <> | Subject | [-git build bug, PATCH] Re: [BUGFIX][PATCH 2/5] memcg: fix init_page_cgroup nid with sparsemem |
| |
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> Date: Mon, 13 Jun 2011 10:09:17 +0900 > Subject: [PATCH 2/5] [BUGFIX] memcg: fix init_page_cgroup nid with sparsemem
This fresh upstream commit commit:
37573e8c7182: memcg: fix init_page_cgroup nid with sparsemem
is causing widespread build failures on latest -git, on x86:
mm/page_cgroup.c:308:3: error: implicit declaration of function ‘node_start_pfn’ [-Werror=implicit-function-declaration] mm/page_cgroup.c:309:3: error: implicit declaration of function ‘node_end_pfn’ [-Werror=implicit-function-declaration]
On any config that has CONFIG_CGROUP_MEM_RES_CTLR=y enabled but CONFIG_NUMA disabled.
For now i've worked it around with the patch below, but the real solution would be to make the page_cgroup.c code not depend on NUMA.
Thanks,
Ingo
diff --git a/init/Kconfig b/init/Kconfig index 412c21b..1593be9 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -639,6 +639,7 @@ config RESOURCE_COUNTERS config CGROUP_MEM_RES_CTLR bool "Memory Resource Controller for Control Groups" depends on RESOURCE_COUNTERS + depends on NUMA select MM_OWNER help Provides a memory resource controller that manages both anonymous -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |