lkml.org 
[lkml]   [2011]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[15/91] [SCSI] Fix Ultrastor asm snippet
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Samuel Thibault <samuel.thibault@ens-lyon.org>

    commit fad4dab5e44e10acf6b0235e469cb8e773b58e31 upstream.

    Commit 1292500b replaced

    "=m" (*field) : "1" (*field)

    with

    "=m" (*field) :

    with comment "The following patch fixes it by using the '+' operator on
    the (*field) operand, marking it as read-write to gcc."
    '+' was actually forgotten. This really puts it.

    Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Signed-off-by: James Bottomley <jbottomley@parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/ultrastor.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/ultrastor.c
    +++ b/drivers/scsi/ultrastor.c
    @@ -306,7 +306,7 @@ static inline int find_and_clear_bit_16(
    "0: bsfw %1,%w0\n\t"
    "btr %0,%1\n\t"
    "jnc 0b"
    - : "=&r" (rv), "=m" (*field) :);
    + : "=&r" (rv), "+m" (*field) :);

    return rv;
    }



    \
     
     \ /
      Last update: 2011-06-16 09:29    [W:4.206 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site