lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Re: Re: Re: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator
    On Wed, Jun 15, 2011 at 10:18:58AM +0200, Tejun Heo wrote:
    > No human being can feel 120usec difference and I can't see how using
    > HIGHPRI is justified here (which is what the code is doing
    > _accidentally_ by using singlethread_workqueue).

    Ooh, one more thing, and even if you insist on using HIGHPRI (please
    don't), you don't need to create workqueue for each device. You can
    just create one for the whole driver in init and destroy it from exit.
    What matters is the HIGHPRI attribute of the workqueue. The number of
    workqueues is completely irrelevant.

    Thank you.

    --
    tejun


    \
     
     \ /
      Last update: 2011-06-15 10:25    [W:0.023 / U:0.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site