Messages in this thread | | | Date | Wed, 15 Jun 2011 10:13:17 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] [RESEND] devres: Fix possible use after free |
| |
Hello, Maxin.
On Tue, Jun 14, 2011 at 03:09:34PM +0100, Maxin B John wrote: > You are right. I shouldn't have mentioned it as dangerous. I was trying to > make this patch description similar to the description present in the > previous patch: > http://www.spinics.net/lists/mm-commits/msg84313.html > > This patch silences the Coverity Prevent's complains about this as > use-after-free bug. Please let me know if the updated patch description is OK. > > " > A freed pointer is passed as an argument to the function "devres_destroy()" in > "kernel/irq/devres.c" and "lib/devres.c". This patch fixes the possible use > after free. > The change silences the static analysis tool (Coverity Prevent) complains > about this as use-after-free bug. > "
Yeap, sounds mostly okay but there's no 'possible use after free'. Maybe something like, "devres uses the pointer value as key after it's freed, which is safe but triggers spurious use-after-free warnings on some static analysis tools. Rearrange code to avoid such warnings".
Thanks.
-- tejun
| |