[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command
I don't care much about pushing this into mainline. It's a bug and
it's up to kernel developers to fix that.
I was aware that kernel devs are bunch of lazy dicks and I'm not going
to do more work for one line patch.


On Tue, Jun 14, 2011 at 6:49 PM, Felipe Balbi <> wrote:
> Hi,
> On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
>> Sorry for the HTML,
>> There is a bug in s3c2410_udc driver, which triggers when using custom
>> UDC command for USB pull-up.
>> As a result driver is always calling user defined UDC command with
>> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
>> just passing the parameter to the user defined function.
> please take a look at Documentation/SubmittingPatches and fix up your
> patch so that it can be applied. Also, when sending patches,
> scripts/ will give you a hint of who you should put on
> Cc ;-)
> --
> balbi

 \ /
  Last update: 2011-06-15 09:33    [W:0.075 / U:1.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site