lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xhci: Add reset on resume quirk for asrock p67 host
On Wed, 15 Jun 2011, Sarah Sharp wrote:

> On Wed, Jun 15, 2011 at 10:29:01PM +0200, Maarten Lankhorst wrote:
> > The asrock p67 xhci controller completely dies on resume,
> > add a quirk for this, to bring the host back online after a suspend.
> >
> > This should be backported to stable kernels as far back as 2.6.34.
>
> Why 2.6.34? Only kernels as old as 2.6.37 had xHCI suspend and resume
> support. Before 2.6.37, the xHCI driver would prevent the system from
> suspending at all.
>
> Otherwise looks fine.
>
> Sarah Sharp
>

> > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> > index 06e7023..42fd032 100644
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -759,6 +759,8 @@ int xhci_resume(struct xhci_hcd *xhci, bool hibernated)
> > msleep(100);
> >
> > spin_lock_irq(&xhci->lock);
> > + if (xhci->quirks & XHCI_RESET_ON_RESUME)
> > + hibernated = 0;

Shouldn't this be "hibernated = true;"? You want the driver to treat
suspend as though it were hibernation, not the other way around.

Alan Stern



\
 
 \ /
  Last update: 2011-06-15 23:03    [W:0.048 / U:6.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site