lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3.0-rc2-tip 7/22] 7: uprobes: mmap and fork hooks.
From
Date
On Tue, 2011-06-07 at 18:29 +0530, Srikar Dronamraju wrote:
> + up_write(&mm->mmap_sem);
> + mutex_lock(&uprobes_mutex);
> + down_read(&mm->mmap_sem);

egads, and all that without a comment explaining why you think that is
even remotely sane.

I'm not at all convinced, it would expose the mmap() even though you
could still decide to tear it down if this function were to fail, I bet
there's some funnies there.



\
 
 \ /
  Last update: 2011-06-15 20:11    [W:0.438 / U:3.164 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site