lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched: select eligible run-queue for RT task
From
Date
On Fri, 2011-06-03 at 22:06 +0800, Hillf Danton wrote:
> When selecting run-queue for a given task, eligible run-queue should be
> returned by checking the CPU affinity of task.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
> kernel/sched_rt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index 88725c9..45b3e0a 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -1006,7 +1006,8 @@ select_task_rq_rt(struct task_struct *p, int
> sd_flag, int flags)
> int cpu;
>
> if (sd_flag != SD_BALANCE_WAKE)
> - return smp_processor_id();
> + return cpumask_test_cpu(smp_processor_id(), &p->cpus_allowed) ?
> + smp_processor_id() : task_cpu(p);

I wonder if we should bother even dhoing a test here. Perhaps a better
solution is just:

if (sd_flag != SD_BALANCE_WAKE)
return task_cpu(p);

-- Steve




\
 
 \ /
  Last update: 2011-06-15 19:53    [W:0.044 / U:0.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site