lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4] coccinelle: if (ret) return ret; return ret; semantic patch
    Date
    Semantic patch to find code that matches this pattern:
    if (...) return ret;
    return ret;

    Version 2:
    Incorporate review comments from Julia Lawall
    Add matches for a number of other similar patterns.

    Version 3:
    Incorporate more review comments from Julia.

    Version 4:
    Add -return ret; +return ret; back to the script
    as this improves Coccinelle's handling of white
    space for this patch.

    Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
    ---
    scripts/coccinelle/misc/doublereturn.cocci | 32 ++++++++++++++++++++++++++++
    1 files changed, 32 insertions(+), 0 deletions(-)
    create mode 100644 scripts/coccinelle/misc/doublereturn.cocci

    diff --git a/scripts/coccinelle/misc/doublereturn.cocci b/scripts/coccinelle/misc/doublereturn.cocci
    new file mode 100644
    index 0000000..3fe40f8
    --- /dev/null
    +++ b/scripts/coccinelle/misc/doublereturn.cocci
    @@ -0,0 +1,32 @@
    +// Removing unecessary code that matches this core pattern:
    +// -if(...) return ret;
    +// return ret;
    +//
    +// Confidence: High
    +// Copyright: (C) 2011 Greg Dietsche GPLv2.
    +// URL: http://www.gregd.org
    +// Comments:
    +// Options: -no_includes
    +
    +virtual patch
    +
    +@depends on patch@
    +expression ret;
    +identifier x, y;
    +identifier f;
    +identifier is_ordinal_table ~= "IS_ORDINAL_TABLE_\(ONE\|TWO\)";
    +@@
    +(
    +//via an isomorphism this also covers x and unlikely(x)
    +-if (likely(x)) return ret;
    +|
    +-if (\(IS_ERR\|IS_ZERO\)(x)) return ret;
    +|
    +-if (is_ordinal_table(x,y)) return ret;
    +|
    +if(<+...f(...)...+>) return ret;
    +|
    +-if (...) return ret;
    +)
    +-return ret;
    ++return ret;
    --
    1.7.2.5


    \
     
     \ /
      Last update: 2011-06-15 17:53    [W:0.115 / U:30.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site