lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] [RFC] genhd: add a new attribute in device structure
On Wed, Jun 15, 2011 at 05:16:28PM +0900, Nao Nishijima wrote:
> Allow users to set the preferred name of device via sysfs interface.
>
> (Exsample) sda -> foo
> # echo foo > /sys/block/sda/preferred_name
>
> Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Suggested-by: Jon Masters <jcm@redhat.com>
> Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>

You don't document this new sysfs file (which is required), nor do you
explain what it is for and how to use it.

Please do that in this patch, and in a Documentation/ABI/ file for any
new sysfs file you create.

I still fail to understand how a "preferred" file will help anyone out
here at all...

greg k-h


\
 
 \ /
  Last update: 2011-06-15 17:43    [W:0.088 / U:10.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site