Messages in this thread | | | Date | Wed, 15 Jun 2011 16:45:29 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 03/16 v2] tracing: Add a proc file to stop tracing and free buffer |
| |
On Wed, Jun 15, 2011 at 10:43:09AM -0400, Steven Rostedt wrote: > On Wed, 2011-06-15 at 16:25 +0200, Frederic Weisbecker wrote: > > On Wed, Jun 15, 2011 at 09:48:44AM -0400, Steven Rostedt wrote: > > > From: Vaibhav Nagarnaik <vnagarnaik@google.com> > > > > > > The proc file entry buffer_size_kb is used to set the size of tracing > > > buffer. > > > > > > The memory to expand the buffer size is kernel memory. Consider > > > a use case where tracing is handled by a user space utility, which acts > > > as a gate keeper for tracing requests. In an OOM condition, tracing is > > > considered a low priority task and if the utility gets killed the ring > > > buffer memory cannot be released back to the kernel. > > > > > > This patch adds a proc file called "free_buffer" whose purpose is to > > > stop tracing and free up the ring buffer when it is closed. > > > > > > > > s/proc/debugfs, right? > > Oops, I didn't even notice it said that. But you are correct, the patch > adds a debugfs not a proc file. > > Not sure it's worth redoing for the changelog though :-/
No big deal, I just wanted to ensure I didn't miss something in the diff.
| |