lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] dvb-usb/technisat-usb2: don't use flush_scheduled_work()
flush_scheduled_work() is deprecated and scheduled to be removed.
technisat-usb2 already sync-cancels the only work item it uses and
there's no reason for it to call flush_scheduled_work(). Don't use
it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Patrick Boettcher <pboettcher@kernellabs.com>
---
I was re-scanning source tree to prepare for deprecation of
flush_scheduled_work() and found out new driver added usage
unnecessarily. Can you please include this patch so that it gets
propagated to linux-next soonish?

Thank you.

drivers/media/dvb/dvb-usb/technisat-usb2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Index: work/drivers/media/dvb/dvb-usb/technisat-usb2.c
===================================================================
--- work.orig/drivers/media/dvb/dvb-usb/technisat-usb2.c
+++ work/drivers/media/dvb/dvb-usb/technisat-usb2.c
@@ -765,10 +765,8 @@ static void technisat_usb2_disconnect(st
/* work and stuff was only created when the device is is hot-state */
if (dev != NULL) {
struct technisat_usb2_state *state = dev->priv;
- if (state != NULL) {
+ if (state != NULL)
cancel_delayed_work_sync(&state->green_led_work);
- flush_scheduled_work();
- }
}

dvb_usb_device_exit(intf);

\
 
 \ /
  Last update: 2011-06-15 15:35    [W:0.026 / U:0.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site