lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net-next 2/2] drivers/net: Remove casts of void *
    From
    2011/6/14 Joe Perches <joe@perches.com>:
    > Unnecessary casts of void * clutter the code.

    > diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c
    > index 484f795..658a192 100644
    > --- a/drivers/net/sis900.c
    > +++ b/drivers/net/sis900.c
    > @@ -482,7 +482,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
    >                ret = -ENOMEM;
    >                goto err_out_cleardev;
    >        }
    > -       sis_priv->tx_ring = (BufferDesc *)ring_space;
    > +       sis_priv->tx_ring = ring_space;
    >        sis_priv->tx_ring_dma = ring_dma;
    >
    >        ring_space = pci_alloc_consistent(pci_dev, RX_TOTAL_SIZE, &ring_dma);
    > @@ -490,7 +490,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
    >                ret = -ENOMEM;
    >                goto err_unmap_tx;
    >        }
    > -       sis_priv->rx_ring = (BufferDesc *)ring_space;
    > +       sis_priv->rx_ring = ring_space;
    >        sis_priv->rx_ring_dma = ring_dma;
    >
    >        /* The SiS900-specific entries in the device structure. */

    sis900 looks good, too.

    --
    Daniele Venzano
    venza@brownhat.org
    http://www.brownhat.org
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-14 10:27    [W:0.020 / U:30.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site