Messages in this thread | | | Subject | Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added | Date | Tue, 14 Jun 2011 20:40:46 +0200 | From | "Michal Nazarewicz" <> |
| |
> On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: >> Is having support for multiple regions a bad thing? Frankly, >> removing this support will change code from reading context passed >> as argument to code reading context from global variable. Nothing >> is gained; functionality is lost.
On Tue, 14 Jun 2011 20:30:07 +0200, Arnd Bergmann wrote: > What is bad IMHO is making them the default, which forces the board > code to care about memory management details. I would much prefer > to have contiguous allocation parameters tuned automatically to just > work on most boards before we add ways to do board-specific hacks.
I see those as orthogonal problems. The code can have support for multiple contexts but by default use a single global context exported as cma_global variable (or some such).
And I'm not arguing against having “contiguous allocation parameters tuned automatically to just work on most boards”. I just don't see the reason to delete functionality that is already there, does not add much code and can be useful.
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |