lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description
On Mon, Jun 13, 2011 at 03:27:17PM +0300, Dan Carpenter wrote:
> On Mon, Jun 13, 2011 at 04:18:29PM +0400, Kirill Smelkov wrote:
> > Both bars=0 and bars=1 were described as meaning to display bars on
> > signal lost. Actually bars=1 means "display bars", but bars=0 means
> > display raw source as is (usually black screen).
>
> Your description up here is much better than the one in the README.
> Maybe just include yours and delete the original.

Thanks for head ups. Something like this:

---- 8< ----
From: Kirill Smelkov <kirr@mns.spb.ru>
Date: Mon, 13 Jun 2011 15:09:31 +0400
Subject: [PATCH v2] staging/easycap: Fix thinko in "bars" module option
description
Both bars=0 and bars=1 were described as meaning to display bars on
signal lost. Actually bars=1 means "display bars", but bars=0 means
display raw source as is (usually black screen).

Instead of changing bars=0 to "_no_ testcard bars ..." as suggested by
Dan Carpenter reword the whole bars description for clarity.

Cc: Tomas Winkler <tomas.winkler@intel.com>
Cc: Mike Thomas <rmthomas@sciolus.org>
Cc: Dan Carpenter <error27@gmail.com>
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
---
drivers/staging/easycap/README | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/easycap/README b/drivers/staging/easycap/README
index 16b8264..dadceb9 100644
--- a/drivers/staging/easycap/README
+++ b/drivers/staging/easycap/README
@@ -60,8 +60,8 @@ Three module parameters are defined:

debug the easycap module is configured at diagnostic level n (0 to 9)
gain audio gain level n (0 to 31, default is 16)
-bars 0 => testcard bars when incoming video signal is lost
- 1 => testcard bars when incoming video signal is lost (default)
+bars whether to display testcard bars when incoming video signal is lost
+ 0 => no, 1 => yes (default)


SUPPORTED TV STANDARDS AND RESOLUTIONS
--
1.7.6.rc1


\
 
 \ /
  Last update: 2011-06-14 18:49    [from the cache]
©2003-2011 Jasper Spaans