lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *
    On 06/14/2011 12:02 AM, Joe Perches wrote:

    > /* Get the message ID */
    > - msg_id = (__be16 *) ((void *) htc_hdr +
    > - sizeof(struct htc_frame_hdr));
    > + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);

    I would never do stuff like this without verifying by sparse that no
    warnings are introduced.

    Sparse warnings should be avoided to keep sparse checks useful.
    Otherwise, important warnings would drown in the noise.

    --
    Regards,
    Pavel Roskin


    \
     
     \ /
      Last update: 2011-06-14 18:43    [W:0.020 / U:0.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site