lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, efi: Do not reserve boot services regions within reserved areas
Op 14-06-11 17:21, Matthew Garrett schreef:
> On Tue, Jun 14, 2011 at 05:03:14PM +0200, Maarten Lankhorst wrote:
>
>> + /* Could not reserve boot area */
>> + if (!size)
>> + continue;
>> +
>> + printk(KERN_INFO PFX "Freeing boot area "
>> + "[0x%llx-0x%llx)\n", start, start+size);
> Probably don't need the printk - we could be dumping a few hundred of
> those.
Ok, I believe you are right about the succesful ones, since memblock=debug
will let you see those anyhow.

Should I change the unsuccesful ones to use memblock_dbg instead of printk?
In that case you can still debug it if needed. Same question for free path,
change printk to memblock_dbg?
>> - "Kernel-defined memdesc doesn't match the one from EFI!\n");
>> + "Kernel-defined memdesc (%lu) "
>> + "doesn't match the one from EFI(%lu)!\n",
>> + sizeof(efi_memory_desc_t), memmap.desc_size);
> And drop this hunk. It's entirely valid for an implementation to do
> this, we should just delete the message entirely.
Ok. Just wasn't sure what to make of it, since that message kept popping up here.

~Maarten


\
 
 \ /
  Last update: 2011-06-14 17:35    [W:0.052 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site