Messages in this thread | | | Subject | Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver | From | Carlos Chinea <> | Date | Tue, 14 Jun 2011 15:09:22 +0300 |
| |
Hi, -- cut-- > > + > > +static int __init ssi_init(void) > > +{ > > + return platform_device_register(&ssi_pdev); > > +} > > +subsys_initcall(ssi_init); > > Looks like you need something here also to prevent this subsys_initcall > on running on all boards. Maybe have a pointer to ssi_pdev that only > gets initialized after omap_ssi_config? > > Then you can have ssi_init fail if no configuration is called: > > if (!pdev) > return -ENODEV; > > return platform_device_register(pdev); >
Right. I'll do those changes.
Thanks, Carlos
| |