Messages in this thread | | | Date | Tue, 14 Jun 2011 00:53:13 -0300 | From | Lucas De Marchi <> | Subject | Re: [PATCH] sysctl: add support for poll() |
| |
* Kay Sievers <kay.sievers@vrfy.org> [2011-06-13 18:05:51 +0200]:
> On Thu, 2011-06-09 at 15:16 +0200, Kay Sievers wrote: > > On Thu, Jun 9, 2011 at 00:17, Andrew Morton <akpm@linux-foundation.org> wrote: > > > > We already have several pollable procfs files, such as > > > fs/proc/base.c:mounts_poll() and I think drivers/md has one. I do > > > think that any work in this area should end up with those custom > > > make-procfs-pollable hacks being identified and removed. > > > > For these files we can probably move the event counter into the > > seq_file structure, and get rid of the dance to kmalloc it and assign > > it to seq_file->private. That might simplify the logic a bit. > > > > [Adding Neil, to get his opinion of moving 'event' so seq_file and get > > rid of the malloc dance] > > I guess, we could do something like this, which looks quite a bit > simpler by moving the poll event counter into the dynamically allocated > seq_file structure itself, instead of having private structures > allocated on top to just carry the counter (patch is just > compile-tested). > > Thanks, > Kay > > --- > drivers/md/md.c | 26 ++++++++------------------ > fs/namespace.c | 4 ++-- > fs/proc/base.c | 2 +- > include/linux/mnt_namespace.h | 1 - > include/linux/seq_file.h | 1 + > mm/swapfile.c | 29 ++++++++--------------------- > 6 files changed, 20 insertions(+), 43 deletions(-)
I've successfully tested this on top of 3.0-rc3 for /proc/mounts and /proc/swaps. I've booted with systemd (that depends on mounts and swaps being pollable) and created a small test using epoll.
Lucas De Marchi
| |