lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3.0-rc2-tip 4/22] 4: Uprobes: register/unregister probes.
From
Date
On Fri, 2011-06-10 at 01:03 +0200, Peter Zijlstra wrote:

> The comment in del_consumer() that says: 'drop creation ref' worries me
> and makes me thing that is the last reference around and the uprobe will
> be freed right there, which clearly cannot happen since its not yet
> removed from the RB-tree.

I agree about that comment. It scared me too, not only about the RB
tree, but the uprobe is used later in that function to drop the
write_rwsem.

I think that comment needs to be changed to something like:

/* Have caller drop the creation ref */
-- Steve




\
 
 \ /
  Last update: 2011-06-13 18:53    [from the cache]
©2003-2011 Jasper Spaans