lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/15] tracing/kprobes: Fix kprobe-tracer to support stack trace
From
Date
On Mon, 2011-06-13 at 13:50 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > > + __ftrace_trace_stack(global_trace.buffer, flags, 3, preempt_count(),
> > > > + NULL);
> > >
> > > pointless linebreak.
> >
> > Again, probably to do with the 80 char limit.
>
> Well, the point of the 80 char limit warning these days is to force a
> cleanup of the code. Breaking the line mindlessly *uglifies* the code
> so it's pointless to do it.
>
> In terms of terminal readability line length up to 90-100 cols is
> acceptable for code that is otherwise not ugly.

I totally agree. I've just had arguments with others that are more 80
character nazi than I am. ;)

-- Steve




\
 
 \ /
  Last update: 2011-06-13 14:17    [from the cache]
©2003-2011 Jasper Spaans