Messages in this thread | | | Date | Mon, 13 Jun 2011 13:42:04 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs() |
| |
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> (2011/06/13 19:19), Ingo Molnar wrote: > > > > * Steven Rostedt <rostedt@goodmis.org> wrote: > > > >> +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace) > >> +{ > >> + WARN_ONCE(1, > >> + KERN_INFO "save_stack_trace_regs() not implemented yet.\n"); > > > > - pointless linebreak > > - we don't add KERN_ tags to WARN*() invocations > > Hm, I just copied save_stack_trace_tsk(). OK, I'll remove it.
Please remove it from save_stack_trace_tsk() as well.
Thanks,
Ingo
| |