lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/15] tracing: Add a free on close control mechanism for buffer_size_kb
From
Date
On Mon, 2011-06-13 at 12:12 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > + switch (cmd) {
> > + case TRACE_RINGBUF_FREE_ON_CLOSE: {
> > + info->free_buffer_on_close = !!arg;
> > + ret = 0;
> > + break;
> > + }
> > }
>
> that doesn't look very tidy.
>
> > @@ -3635,9 +3700,12 @@ static const struct file_operations tracing_pipe_fops = {
> > };
> >
> > static const struct file_operations tracing_entries_fops = {
> > - .open = tracing_open_generic,
> > + .open = tracing_entries_open,
> > .read = tracing_entries_read,
> > .write = tracing_entries_write,
> > + .unlocked_ioctl = tracing_entries_ioctl,
> > + .compat_ioctl = tracing_entries_ioctl,
>
> i don't like it at all that you are adding to the ftrace ABI here.
> The *only* premise of the whole /debug/tracing/ muck was to allow it
> to be human-parseable and scripted - an ioctl is clearly outside that
> scope. Instead of increasing the mess in /debug/tracing/ we want
> clean tracing done via the perf ABI ...

Vaibhav originally suggested adding a "buffer_free" file that you could
write into and cause it to free the buffer. It would do this on the
release so you could also have an app (like Google needs) to open this
file and if the app dies, it will automatically free the buffer closing
it.

https://lkml.org/lkml/2011/3/17/366

I didn't really like adding another file to the debugfs system, and
recommended the ioctl. It seemed like a nice "unix" fit. But if you want
to go back to the Vaibhav's original method, which will stay in the
frame of "human-parseable and scripted". We could do that.

-- Steve




\
 
 \ /
  Last update: 2011-06-13 13:43    [W:0.112 / U:1.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site