lkml.org 
[lkml]   [2011]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/15] KVM: MMU: split kvm_mmu_free_page
On 06/10/2011 06:50 AM, Xiao Guangrong wrote:
> >> +static void kvm_mmu_free_unlock_parts(struct kvm_mmu_page *sp)
> >> +{
> >> + list_del(&sp->link);
> >> + free_page((unsigned long)sp->spt);
> >> kmem_cache_free(mmu_page_header_cache, sp);
> >> }
> >
> > The list_del() must be run under a lock, no? it can access kvm->arch.active_mmu_pages.
> >
>
> In prepare path, we have moved the sp from active_mmu_pages to invlaid_list.

It still needs to be accessed under a lock, no matter which list is used.

--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2011-06-12 10:35    [W:0.103 / U:0.060 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site