lkml.org 
[lkml]   [2011]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] kernel/sched.c: Fix array initialization typo
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Mon, 13 Jun 2011 00:35:49 +0300
>
> On Sun, Jun 12, 2011 at 03:31:07PM -0600, Jean Sacren wrote:
> > The fix makes certain so that the size of the initialized arrays doesn't
> > go beyond the boundary set by the array size of 40.
>
> Why would it possibly do that?

With that ',' comma, doesn't it imply there might be the 41st element in
the array? Despite the fact that that element is bogus.

Further, if the comma is there, what's the benefit? I know you're cool,
but is it cool in code that way as well?
>
> And it's not a typo.

What is it then?
>
> > @@ -1383,7 +1383,7 @@ static const int prio_to_weight[40] = {
> > /* 0 */ 1024, 820, 655, 526, 423,
> > /* 5 */ 335, 272, 215, 172, 137,
> > /* 10 */ 110, 87, 70, 56, 45,
> > - /* 15 */ 36, 29, 23, 18, 15,
> > + /* 15 */ 36, 29, 23, 18, 15
> > };
> >
> > /*
> > @@ -1401,7 +1401,7 @@ static const u32 prio_to_wmult[40] = {
> > /* 0 */ 4194304, 5237765, 6557202, 8165337, 10153587,
> > /* 5 */ 12820798, 15790321, 19976592, 24970740, 31350126,
> > /* 10 */ 39045157, 49367440, 61356676, 76695844, 95443717,
> > - /* 15 */ 119304647, 148102320, 186737708, 238609294, 286331153,
> > + /* 15 */ 119304647, 148102320, 186737708, 238609294, 286331153
> > };

--
Jean Sacren


\
 
 \ /
  Last update: 2011-06-13 00:05    [from the cache]
©2003-2011 Jasper Spaans