Messages in this thread | | | Date | Fri, 10 Jun 2011 09:56:18 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH] sysctl: remove impossible condition check |
| |
On Fri, 10 Jun 2011, Lucas De Marchi wrote:
> Remove checks for conditions that will never happen. If procname is NULL > the loop would already had bailed out, so there's no need to check it > again. > > At the same time this also compacts the function find_in_table() by > refactoring it to be easier to read. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Looks good to me.
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |