Messages in this thread | | | Date | Fri, 10 Jun 2011 19:58:58 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning instead of failing |
| |
On Fri, Jun 10, 2011 at 11:54:16AM -0700, David Rientjes wrote: > On Fri, 10 Jun 2011, Russell King - ARM Linux wrote: > > > > Should one submit a patch adding a warning to GFP_DMA allocations > > > w/o ZONE_DMA, or the idea of the original patch is wrong? > > > > Linus was far from impressed by the original commit, saying: > > | Using GFP_DMA is reasonable in a driver - on platforms where that > > | matters, it should allocate from the DMA zone, on platforms where it > > | doesn't matter it should be a no-op. > > > > So no, not even a warning. > > > > Any words of wisdom for users with CONFIG_ZONE_DMA=n that actually use > drivers where they need GFP_DMA? The page allocator should just silently > return memory from anywhere?
See Linus' reply. I quote again "on platforms where it doesn't matter it should be a no-op". If _you_ have a problem with that _you_ need to discuss it with _Linus_, not me. I'm not going to be a middle-man sitting between two people with different opinions.
| |