Messages in this thread | | | Date | Fri, 10 Jun 2011 11:17:56 -0700 | Subject | Re: [PATCH 04/10] MCE: Move ADDR/MISC reading code into common function | From | Tony Luck <> |
| |
On Fri, Jun 10, 2011 at 2:33 AM, Borislav Petkov <bp@amd64.org> wrote: >> Used for next patch. > > Yeah, let's have a more general comment here like "save us some code > duplication"
Sure.
>> +/* >> + * Read ADDR and MISC registers. >> + */ > > No need for that comment, IMO. Function is small enough and the macros > speak for themselves :).
Ok.
>> +static void mce_read_aux(struct mce *m, int i) > > inline?
Compiler will possibly do this anyway - I hate to second guess it. I'm not a big fan of inline for code that isn't in the critical performance path.
-Tony
| |