Messages in this thread | | | Date | Fri, 10 Jun 2011 11:08:41 -0700 | Subject | Re: [PATCH 02/10] MCE: save most severe error information | From | Tony Luck <> |
| |
2011/6/10 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>: > Could you clarify why we have to use mces_seen after mce_end(), please?
In part 10 I add: + if (worst == MCE_AR_SEVERITY) { + mce_action_required(&m, msg, regs); + kill_it = 0; + }
Which happens after mce_end() ... and wants to access the struct mce that we filled out for this processor.
But it is possible that we don't need it - your comments to later parts of this patch series point out that better severity table entries could cover the checks for ADDRV and MISCV being set, and make the error immediately fatal, rather than leaving it until this late stage to do so.
I think we only actually need to save the address from the mce structure.
-Tony
| |