lkml.org 
[lkml]   [2011]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Documentation: update kmemleak architecture support info
On Fri, 10 Jun 2011 15:55:18 +0100 Catalin Marinas wrote:

> On Fri, Jun 10, 2011 at 08:18:50AM +0100, Daniel Baluta wrote:
> > On 06/10/2011 10:09 AM, Maxin B John wrote:
> > > -Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze and tile.
> > > +Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze, tile,
> > > +s390 and mips.Please check DEBUG_KMEMLEAK dependencies in lib/Kconfig.debug
> > > +for supported platforms.
> > The point of adding my generic comment was to remove direct
> > references to supported platforms.
> >
> > In this case your patch should remove the line specifying supported
> > platforms (x86, arm, powerpc, etc) and only add the line pointing
> > the reader to lib/Kconfig.debug.
> >
> > When a new platform will be supported lib/Kconfig.debug will
> > be surely modified, and the change will be consistent with
> > information in kmemleak.txt.
>
> I think Daniel's suggestion is better, we don't have to worry about
> changing the documentation every time we add a new architecture.
>
> In addition to that, I would say "supported architectures" rather than
> platforms.

Maxin,

Please send an updated patch without the currently-supported list
of architectures.

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-06-10 19:57    [W:0.148 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site