Messages in this thread | | | Date | Thu, 9 Jun 2011 23:40:38 -0700 (PDT) | From | Hugh Dickins <> | Subject | Re: [PATCH 5/7] tmpfs: simplify prealloc_page |
| |
On Fri, 10 Jun 2011, Shaohua Li wrote: > On Fri, 2011-06-10 at 06:39 +0800, Hugh Dickins wrote: > > @@ -1492,11 +1460,19 @@ repeat: > > SetPageUptodate(filepage); > > if (sgp == SGP_DIRTY) > > set_page_dirty(filepage); > > + } else { > Looks info->lock unlock is missed here. > Otherwise looks good to me.
Many thanks for catching that! Replacements for this patch, and the next which then rejects, follow as replies.
Hugh
| |