lkml.org 
[lkml]   [2011]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRace inotify_rm_watch vs umount
    Date
    Hi,

    I'm looking the race inotify_rm_watch() vs umount(). This race become the
    cause of Oops. You can see the oops at

    https://bugzilla.kernel.org/show_bug.cgi?id=22602

    So, what race?

    umount inotify_rm_watch
    ... fsnotify_destroy_mark()
    fsnotify_destroy_inode_mark()
    /* removed from i_fsnotify_marks */
    generic_shutdown_super()
    fsnotify_unmount_inodes()
    put_super()
    iput()
    iput_final()
    /* this is after put_super() */

    Like above, inotify doesn't guarantee to call final iput() before
    put_super(). With this violation, FS driver can oops.

    Well, so, what are requested for inotify? We can't simply take
    sb->s_umount in inotify_rm_watch()?

    Any ideas?

    Thanks.
    --
    OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


    \
     
     \ /
      Last update: 2011-06-10 13:23    [W:0.022 / U:0.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site