lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[054/146] macvlan: fix panic if lowerdev in a bond
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Eric Dumazet <eric.dumazet@gmail.com>

    [ Upstream commit d93515611bbc70c2fe4db232e5feb448ed8e4cc9 ]

    commit a35e2c1b6d905 (macvlan: use rx_handler_data pointer to store
    macvlan_port pointer V2) added a bug in macvlan_port_create()

    Steps to reproduce the bug:

    # ifenslave bond0 eth0 eth1

    # ip link add link eth0 up name eth0#1 type macvlan
    ->error EBUSY

    # ip link add link eth0 up name eth0#1 type macvlan
    ->panic

    Fix: Dont set IFF_MACVLAN_PORT in error case.

    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/macvlan.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/macvlan.c
    +++ b/drivers/net/macvlan.c
    @@ -586,8 +586,8 @@ static int macvlan_port_create(struct ne
    err = netdev_rx_handler_register(dev, macvlan_handle_frame, port);
    if (err)
    kfree(port);
    -
    - dev->priv_flags |= IFF_MACVLAN_PORT;
    + else
    + dev->priv_flags |= IFF_MACVLAN_PORT;
    return err;
    }




    \
     
     \ /
      Last update: 2011-06-01 10:15    [W:0.035 / U:1.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site