Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index | Date | Thu, 02 Jun 2011 09:27:23 +0930 |
| |
On Wed, 1 Jun 2011 03:24:29 -0400, Mark Wu <dwu@redhat.com> wrote: > Current index allocation in virtio-blk is based on a monotonically > increasing variable "index". It could cause some confusion about disk > name in the case of hot-plugging disks. And it's impossible to find the > lowest available index by just maintaining a simple index. So it's > changed to use ida to allocate index via referring to the index > allocation in scsi disk. > > Signed-off-by: Mark Wu <dwu@redhat.com>
Hi Mark,
I don't believe that we do disk probes in parallel, so the spinlock is unnecessary. Otherwise, this looks good.
Thanks, Rusty.
| |