Messages in this thread | | | Date | Wed, 01 Jun 2011 12:03:11 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware |
| |
On 05/29/2011 02:13 PM, Minchan Kim wrote: > In async mode, compaction doesn't migrate dirty or writeback pages. > So, it's meaningless to pick the page and re-add it to lru list. > > Of course, when we isolate the page in compaction, the page might > be dirty or writeback but when we try to migrate the page, the page > would be not dirty, writeback. So it could be migrated. But it's > very unlikely as isolate and migration cycle is much faster than > writeout. > > So, this patch helps cpu and prevent unnecessary LRU churning. > > Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> > Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > Acked-by: Johannes Weiner<hannes@cmpxchg.org> > Acked-by: Mel Gorman<mgorman@suse.de> > Cc: Rik van Riel<riel@redhat.com> > Cc: Andrea Arcangeli<aarcange@redhat.com> > Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
ACked-by: Rik van Riel <riel@redhat.com>
| |