lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] mfd: global Suspend and resume support of ehci and ohci
    Hi,

    On Wed, Jun 01, 2011 at 03:54:38PM +0200, Rafael J. Wysocki wrote:
    > > +static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
    > > + .suspend = usbhs_suspend,
    > > + .resume = usbhs_resume,
    > > +};
    >
    > Please add .freeze()/.thaw() and .poweroff()/.restore() callbacks too.
    > They may point to the same routines, but must be present.
    >
    > You can actually use the SIMPLE_DEV_PM_OPS() convenience macro for this
    > purpose.

    good point. BTW, do we need this #ifdef CONFIG_PM stuff which has been
    popping on most drivers recently ? To me it looks like driver.pm field
    is always available even if PM is disabled, so what's the point ? Saving
    a few bytes ?

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-06-01 16:35    [W:0.042 / U:0.356 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site