lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/8] MFD: twl4030-audio: Rename platform data
Date
On Wednesday 01 June 2011 16:00:34 Tony Lindgren wrote:
> Yeah, most of it might be possible to describe with just a flags
> like TWL_HAS_VIBRA etc.

Or TWL_BOARD_HAS_VIBRA, TWL_BOARD_HAS_CODEC...

For the audio part it is a bit complicated than that:
different base frequencies, for twl6040 we have parameters for Vibra (twl4030
class only have the coexistence). The soc codec has a list of misc parameters
for board specific configurations as well (not all board using them).
I was thinking to switch the MFD driver(s) to use flags to specify the needed
child, and change the child drivers to deal with the missing platform data
themselves.
In that way, board files can pass the vibra/codec platform data to the new
i2c_twl file for example, and provide flags to enable functionality.

> > I'll take a look, but I think it is not going to be part of v2 of this
> > series.
>
> We should not do renaming before the clean-up though, it gets
> classified as "unnecesary churn".

The changes in board files are minimal. The biggest part is the code move, and
that will remain the same now or later...

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-06-01 15:19    [W:0.064 / U:2.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site