lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/8] MFD: twl4030-audio: Rename platform data
Date
On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
>
> Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
> something in common-board-devices.c to get rid of the cut and paste
> duplication in every board-*.c file?

Yes, it would make sense, since most of the board has similar configuration,
and we have lots of duplicated code around.

> Maybe you could have a generic twl_init function that allows overriding
> things like keypad with board specific configuration?

We might need also support for overriding other configurations
(audio/codec/vibra for sure needs that).

I'll take a look, but I think it is not going to be part of v2 of this series.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-06-01 14:57    [W:0.037 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site