lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning instead of failing
    2011/6/1 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>:
    > Please be more polite to other people. After a197b59ae6 all allocations
    > with GFP_DMA set on nodes without ZONE_DMA fail nearly silently (only
    > one warning during bootup is emited, no matter how many things fail).
    > This is a very crude change on behaviour. To be more civil, instead of
    > failing emit noisy warnings each time smbd. tries to allocate a GFP_DMA
    > memory on non-ZONE_DMA node.
    >
    > This change should be reverted after one or two major releases, but
    > we should be more accurate rather than hoping for the best.
    >
    > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
    > Cc: David Rientjes <rientjes@google.com>
    > Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
    > Cc: Mel Gorman <mel@csn.ul.ie>
    > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Cc: Rik van Riel <riel@redhat.com>
    > Cc: Andrew Morton <akpm@linux-foundation.org>

    Instaed of, shouldn't we revert a197b59ae6? Some arch don't have
    DMA_ZONE at all.
    and a197b59ae6 only care x86 embedded case. If we accept your patch, I
    can imagine
    other people will claim warn foold is a bug. ;)

    However, I think, you should explain which platform and drivers hit
    this breakage.
    Otherwise developers can't learn which platform should care.

    Thanks.


    \
     
     \ /
      Last update: 2011-06-01 14:41    [W:3.897 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site