lkml.org 
[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sched: shorten setting the allowed cpu mask of task
From
On Fri, May 6, 2011 at 8:52 PM, Hillf Danton <dhillf@gmail.com> wrote:
> When setting the allowed cpu mask for a given task, if the task is
> already bound to certain cpu, after checking the validity of the new

Maybe we don't need to restrict it only on task bound to certain cpu.

> mask of allowed cpus, job is done, and no further efforts needed for
> the valid case as well.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/kernel/sched.c    2011-04-27 11:48:50.000000000 +0800
> +++ b/kernel/sched.c    2011-05-06 20:39:58.000000000 +0800
> @@ -5899,9 +5899,9 @@ again:
>                goto out;
>        }
>
> -       if (unlikely((p->flags & PF_THREAD_BOUND) && p != current &&
> -                    !cpumask_equal(&p->cpus_allowed, new_mask))) {
> -               ret = -EINVAL;
> +       if ((p->flags & PF_THREAD_BOUND) && p != current) {
> +               if (!cpumask_equal(&p->cpus_allowed, new_mask))

IOW, we could make '!cpumask_equal(&p->cpus_allowed, new_mask)'
be a separated condition. And I don't see any potential problem with it.

Thanks,
Yong


> +                       ret = -EINVAL;
>                goto out;
>        }
>



--
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-09 06:41    [W:0.127 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site