lkml.org 
[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci, e1000e: Add and use __pci_disable_link_state
On Sun, 08 May 2011 11:54:32 -0700
Yinghai Lu <yinghai@kernel.org> wrote:

>
> Need to use it in _e1000e_disable_aspm.
> when aer happens,
> pci_walk_bus already have down_read(&pci_bus_sem)...
> then report_slot_reset
> ==> e1000_io_slot_reset
> ==> e1000e_disable_aspm
> ==> pci_disable_link_state...
>
> We can not use pci_disable_link_state, and it will try to hold pci_bus_sem again.
>
> Try to have __pci_disable_link_state that will not need to hold pci_bus_sem.

What about the other callers of e1000e_disable_aspm? Do they already
have the lock held or is it just reset that needs the already locked
version?

> +extern void __pci_disable_link_state(struct pci_dev *pdev, int state);
> extern void pcie_clear_aspm(void);
> extern void pcie_no_aspm(void);
> #else

pci_disable_link_state_locked would be more descriptive and would match
other usage in the kernel.

Thanks,

--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2011-05-09 23:37    [W:0.093 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site