Messages in this thread | | | Subject | Re: [PATCH net-next 5/4] tulip: xircom_cb: Remove useless func_enter and func_exit | From | Joe Perches <> | Date | Mon, 09 May 2011 12:17:03 -0700 |
| |
On Mon, 2011-05-09 at 12:10 -0700, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Mon, 09 May 2011 12:08:01 -0700 > > On Mon, 2011-05-09 at 11:47 -0700, David Miller wrote: > >> With the advent of the function tracer, those silly function entry/exit > >> logging things are entirely superfluous. > >> They make the code look ugly too. > > I don't much like a lot of debugging messages > > throughout drivers/net, but that's a whole 'nother > > set of patches. > >> Please do that and respin this patch set, thanks Joe! > > How 'bout I just add another patch to delete them. > > Signed-off-by: Joe Perches <joe@perches.com> > How about you just respin the patch set as I asked you to? > It makes no sense to "fix" something you're just going to > delete in the very next commit.
Grumble. 'Cause it's about 20 minutes work for almost _no_ value.
| |