lkml.org 
[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] hpsa: Change memset using sizeof(ptr) to sizeof(*ptr)
On Sun, May 08, 2011 at 11:32:40PM -0700, Joe Perches wrote:
> Not at all sure this is correct or appropriate to change,
> but this seems odd.
>
> Found via coccinelle script

Ack.

-- steve

>
> @@
> type T;
> T* ptr;
> expression E1;
> @@
>
> * memset(E1, 0, sizeof(ptr));
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/scsi/hpsa.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 415ad4f..c8d97b4 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -1308,7 +1308,7 @@ static void hpsa_scsi_do_simple_cmd_with_retry(struct ctlr_info *h,
> int retry_count = 0;
>
> do {
> - memset(c->err_info, 0, sizeof(c->err_info));
> + memset(c->err_info, 0, sizeof(*c->err_info));
> hpsa_scsi_do_simple_cmd_core(h, c);
> retry_count++;
> } while (check_for_unit_attention(h, c) && retry_count <= 3);
>


\
 
 \ /
  Last update: 2011-05-09 15:55    [from the cache]
©2003-2011 Jasper Spaans