Messages in this thread | | | Date | Mon, 9 May 2011 14:40:23 +0200 | From | Mark Brown <> | Subject | Re: [PATCHv2 -next] MFD: MFD module of DA9052 PMIC driver |
| |
On Mon, May 09, 2011 at 04:03:41PM +0530, Ashish Jangam wrote:
> > > +static void da9052_irq_sync_unlock(struct irq_data *data) > > > +{ > > > + struct da9052 *da9052 = irq_data_get_irq_chip_data(data); > > > + struct da9052_irq_data *irq_data = irq_to_da9052_irq(da9052, > > > + data->irq); > > > + > > > + da9052_mask_events(da9052, irq_data->event); > > > + mutex_unlock(&da9052->irq_lock);
> > What happens if an event was enabled while the bus was locked?
Fix your MUA to word wrap within paragraphs.
> Event stays in the hardware till it's not explicitly cleared. Hence > there won't be any event loss.
You're missing the point here. You've not understood what the purpose of the lock and unlock are - they should be syncing back changes to the mask state that were made while the lock was held. This is doing something totally different.
| |