[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 04/11] ptrace: implement PTRACE_INTERRUPT

On Sun, May 08, 2011 at 11:58:20PM +0200, Denys Vlasenko wrote:
> Are rules for PTRACE_INTERRUPT the same? That is, what happens
> if a different trap is taken?

Oh, PTRACE_INTERRUPT is different. If it's scheduled, it will
eventually happen. Other traps may happen before but INTERRUPT trap
will take place before control is returned to userland.

> Can you add API notes in the header, above corresponding defines? -
> --- a/include/linux/ptrace.h
> +++ b/include/linux/ptrace.h
> @@ -48,6 +48,7 @@
> #define PTRACE_SETREGSET 0x4205
> <============================================ ADD COMMENT HERE
> #define PTRACE_SEIZE 0x4206
> <============================================ ADD COMMENT HERE
> +#define PTRACE_INTERRUPT 0x4207
> They will be much more visible and up-to-date there than in Documentation,
> git logs etc...

Hmmm... I was thinking about writing a proper ptrace API doc with
example programs under Documentation/. It's userland visible API so
it shouldn't change all that much and the amount of necessary
documentation would be too much for comments.

Thank you.


 \ /
  Last update: 2011-05-09 12:11    [W:0.116 / U:0.796 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site