lkml.org 
[lkml]   [2011]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 3/5] pch_dma: Fix DMA setting issue
    Date
    Currently, Direct-Start mode(*) is enabled.
    Our IOH's devices must not use this mode.
    This causes unexpected behavior.
    This patch deletes Direct-Start setting.
    (*) This mode is used in order for CPU to generate the DMA request.

    Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
    ---
    drivers/dma/pch_dma.c | 7 -------
    1 files changed, 0 insertions(+), 7 deletions(-)

    diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
    index f73686e..0ecf227 100644
    --- a/drivers/dma/pch_dma.c
    +++ b/drivers/dma/pch_dma.c
    @@ -254,9 +254,6 @@ static bool pdc_is_idle(struct pch_dma_chan *pd_chan)

    static void pdc_dostart(struct pch_dma_chan *pd_chan, struct pch_dma_desc* desc)
    {
    - struct pch_dma *pd = to_pd(pd_chan->chan.device);
    - u32 val;
    -
    if (!pdc_is_idle(pd_chan)) {
    dev_err(chan2dev(&pd_chan->chan),
    "BUG: Attempt to start non-idle channel\n");
    @@ -282,10 +279,6 @@ static void pdc_dostart(struct pch_dma_chan *pd_chan, struct pch_dma_desc* desc)
    channel_writel(pd_chan, NEXT, desc->txd.phys);
    pdc_set_mode(&pd_chan->chan, DMA_CTL0_SG);
    }
    -
    - val = dma_readl(pd, CTL2);
    - val |= 1 << (DMA_CTL2_START_SHIFT_BITS + pd_chan->chan.chan_id);
    - dma_writel(pd, CTL2, val);
    }

    static void pdc_chain_complete(struct pch_dma_chan *pd_chan,
    --
    1.7.4


    \
     
     \ /
      Last update: 2011-05-09 05:43    [W:0.036 / U:95.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site