Messages in this thread | | | Date | Sun, 08 May 2011 15:46:22 -0700 (PDT) | Subject | Re: [PATCH net-next-2.6] ipheth: Properly distinguish length and alignment in URBs and skbs | From | David Miller <> |
| |
From: Ben Hutchings <bhutchings@solarflare.com> Date: Tue, 03 May 2011 18:49:25 +0100
> The USB protocol this driver implements appears to require 2 bytes of > padding in front of each received packet. This used to be equal to > the value of NET_IP_ALIGN on x86, so the driver abused that constant > and mostly worked, but this is no longer the case. The driver also > mixed up the URB and packet lengths, resulting in 2 bytes of junk at > the end of the skb. > > Introduce a private constant for the 2 bytes of padding; fix this > confusion and check for the under-length case. > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> > --- > Compile-tested only, as I'm not cool enough for an iPhone either. > This is applicable to net-next-2.6 or v2.6.38.
I've applied this to net-2.6 and will conditionally queue it up for -stable, if we need further fixups we can add relative patches.
Thanks.
| |